Support multiple rustdoc versions: v16 (stable), v21 (beta), v22 (nightly). #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New nightly is out and uses rustdoc v22. Let's see how small of a change I can make adding that be. |
Answer: a dependency-only change, to update to a newer |
obi1kenobi
changed the title
epage
approved these changes
Sep 28, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the adapter and indexed crate code to
trustfall-rustdoc-adapter, whose major versions match the rustdoc format version number they can parse and query.Added
trustfall_rustdoc, a general-purpose rustdoc querying crate that can support any combination of versions we choose to add, and where versions can be enabled/disabled using crate features. It usestrustfall-rustdoc-adapter. Yes, I made a mess of dashes and underscores again :( No, there's not much that can be done about it now.Now
cargo-semver-checkscontains only the CLI app + rustdoc generation facilities + semver queries and associated checking logic.Tested by generating both stable and beta versions of the test rustdocs and running
cargo test. Merging #131 is a prerequisite for actually testing on stable and beta (because we needRUSTC_BOOTSTRAP), so I'll add the test matrix across versions after this and #131 both merge.Resolves #126.